-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tsc): audience property is not mandatory on verifyIdToken #972
Conversation
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 19 19
Lines 4023 4023
Branches 488 454 -34
=======================================
Hits 3737 3737
Misses 286 286
Continue to review full report at Codecov.
|
@bshaffer can I trouble you to take a look here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will wait on @bshaffer for feedback, but this looks reasonable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused as to what this actually does, as our verify-iap sample currently works with a null
audience. But otherwise, this is LGTM
This is just a fix of TypeScript definition, not business logic involved. The sample you mention works because |
As code says,
audience
property is not mandatory onOAuth2Client.prototype.verifyIdToken()
call despite the TypeScript interface currently requires it, so I have just updated the interface to make it optional.