-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pkce support #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please let Carl to look as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!
Co-authored-by: Vishwaraj Anand <vishwaraj.anand00@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
In order to support PKCE for OAuth2, adds the following public methods:
OAuth2::generateCodeVerifier(): string
OAuth2::setCodeVerifier(?string $codeVerifier): void
OAuth2::getCodeVerifier(): ?string
Usage
Authorization Request
Token Request
See b/270198724