fix: run_local_server block when waiting for response #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clundin25
reviewed
Oct 19, 2022
| @@ -449,6 +449,7 @@ def run_local_server( | |||
| success_message=_DEFAULT_WEB_SUCCESS_MESSAGE, | |||
| open_browser=True, | |||
| redirect_uri_trailing_slash=True, | |||
| timeout_seconds=None, | |||
There was a problem hiding this comment.
Can you add inline documentation for this new parameter?
There was a problem hiding this comment.
Done, added the documentation with the new commit.
|
LGTM - Just need the documentation updated |
clundin25
reviewed
Oct 20, 2022
google_auth_oauthlib/flow.py
Outdated
| @@ -478,6 +479,9 @@ def run_local_server( | |||
| in the user's browser. | |||
| redirect_uri_trailing_slash (bool): whether or not to add trailing | |||
| slash when constructing the redirect_uri. Default value is True. | |||
| timeout_seconds (int): It will raise an error after the timeout timing | |||
| if there are no credentials response. The value is in seconds. | |||
There was a problem hiding this comment.
Suggested change
| if there are no credentials response. The value is in seconds. | |
| if there are no credentials response. The value is in seconds. | |
| When set to None there is no timeout. |
clundin25
approved these changes
Oct 20, 2022
|
Thank you for your contribution @wonggw ! |
|
Please run the workflows again. Had to push a new commit to fix the lint. |
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #239 🦕