Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: run_local_server block when waiting for response #245

Merged
merged 3 commits into from
Oct 20, 2022
Merged

fix: run_local_server block when waiting for response #245

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dd367d
fix: run_local_server block when waiting for response
wonggw Oct 19, 2022
9f6cb70
fix: Add inline documentation
wonggw Oct 20, 2022
d89dbe9
fix: lint
wonggw Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions google_auth_oauthlib/flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,7 @@ def run_local_server(
success_message=_DEFAULT_WEB_SUCCESS_MESSAGE,
open_browser=True,
redirect_uri_trailing_slash=True,
timeout_seconds=None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add inline documentation for this new parameter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, added the documentation with the new commit.

**kwargs
):
"""Run the flow using the server strategy.
Expand Down Expand Up @@ -478,6 +479,10 @@ def run_local_server(
in the user's browser.
redirect_uri_trailing_slash (bool): whether or not to add trailing
slash when constructing the redirect_uri. Default value is True.
timeout_seconds (int): It will raise an error after the timeout timing
if there are no credentials response. The value is in seconds.
When set to None there is no timeout.
Default value is None.
kwargs: Additional keyword arguments passed through to
:meth:`authorization_url`.

Expand All @@ -503,6 +508,7 @@ def run_local_server(

print(authorization_prompt_message.format(url=auth_url))

local_server.timeout = timeout_seconds
local_server.handle_request()

# Note: using https here because oauthlib is very picky that
Expand Down