-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate urls for external accounts #1031
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…personation url (#1) [b-193694420] adding url validation for token url and service account impersonation url * adding coverage of empty hostname to invalid token url * Add more tests to enlarge the coverage Co-authored-by: Jin Qin <qinjin@google.com>
BigTailWolf
requested review from
arithmetic1728,
sai-sunder-s and
a team
as code owners
April 22, 2022 21:12
arithmetic1728
changed the title
[Bug 193694420] adding validation of token url and service account im…
fix: validate urls for external accounts
Apr 22, 2022
Please change the commit message to "fix: ". The commit has to start with |
arithmetic1728
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 22, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 22, 2022
Unit test failed:
Lint nox session also failed. Please run |
arithmetic1728
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 25, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 25, 2022
lsirac
reviewed
Apr 27, 2022
lsirac
approved these changes
Apr 27, 2022
LGTM, thanks Jin! |
lsirac
reviewed
Apr 27, 2022
arithmetic1728
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 28, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 28, 2022
arithmetic1728
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 28, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 28, 2022
|
arithmetic1728
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 29, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Apr 29, 2022
arithmetic1728
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 3, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 3, 2022
arithmetic1728
approved these changes
May 3, 2022
arithmetic1728
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
May 3, 2022
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
May 3, 2022
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
May 3, 2022
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 7, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.0](v2.6.6...v2.7.0) (2022-06-07) ### Features * add experimental enterprise cert support ([#1052](#1052)) ([dda7dda](dda7dda)) * add experimental GDCH support ([#1022](#1022)) ([5367aac](5367aac)) * Pluggable auth support ([#995](#995)) ([62daa73](62daa73)) ### Bug Fixes * validate urls for external accounts ([#1031](#1031)) ([61b1f15](61b1f15)) ### Reverts * pluggable auth support [#995](#995) ([#1039](#1039)) ([513d999](513d999)) * revert experimental GDCH support ([#1022](#1022)) ([#1042](#1042)) ([c720995](c720995)) ### Documentation * fix changelog header to consistent size ([#1046](#1046)) ([e64d084](e64d084)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[b-193694420] adding url validation for token url and service account impersonation url
Co-authored-by: Jin Qin qinjin@google.com
Blacken successful
Lint successful
nox
test added and 100% covered