Make service_account_email public, read-only #76

theacodes · 2016-11-07T21:38:40Z

No description provided.

google/auth/app_engine.py

+        if self._service_account_id is not None:
+            return self._service_account_id
+        else:
+            return app_identity.get_service_account_name()


google/auth/compute_engine/credentials.py

+    def service_account_email(self):
+        """The service account email.
+
+        .. Note: This is not guarenteed to be set until :meth`refresh` has been


tests/compute_engine/test_credentials.py

@@ -58,7 +60,7 @@ def test_refresh_success(self, get_mock, now_mock):
            datetime.datetime.min + datetime.timedelta(seconds=500))

        # Check the credential info
-        assert (self.credentials._service_account_email ==
+        assert (self.credentials.service_account_email ==


Make service_account_email public, read-only

0050aba

theacodes assigned dhermes Nov 7, 2016

dhermes approved these changes Nov 7, 2016

View reviewed changes

Jon Wayne Parrott added 3 commits November 7, 2016 14:44

Fix typo, cache

bc4f65a

Make admonition lowercase

eaa746c

Remove some private usage of _service_account_credentials.

d4c381b

theacodes merged commit 61ffb05 into master Nov 8, 2016

theacodes deleted the public-service-account-name branch November 8, 2016 17:30

theacodes unassigned dhermes Oct 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make service_account_email public, read-only #76

Make service_account_email public, read-only #76

theacodes commented Nov 7, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Make service_account_email public, read-only #76

Make service_account_email public, read-only #76

Conversation

theacodes commented Nov 7, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.