fix: Raise exception on error from iam_sign_endpoint #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise an exception when the sign_bytes function of an impersonated credential gets an error from the iam_sign_endpoint. (currently, it fails with a KeyError exception)
bgirschig
requested review from
arithmetic1728,
silvolu and
a team
as code owners
google-cla
bot
added
the
cla: yes
tseaver
suggested changes
Oct 1, 2021
| response_data = response.json() | ||
|
|
||
| if "error" in response: | ||
| raise Exception(response_data["error"]) |
There was a problem hiding this comment.
The exception type should be based on the status code from the response (which we ought to be checking before extracting JSON, anyway).
We will also need one or more new tests for the error case.
|
fixed in #905 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an exception when the sign_bytes function of an impersonated credential gets an error from the iam_sign_endpoint.
(currently, it fails with a KeyError exception)