Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
coryan committed Jun 19, 2024
1 parent b2c1d55 commit 08c1e9a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ namespace {

void CreateBucketWithObjectRetention(google::cloud::storage::Client client,
std::vector<std::string> const& argv) {
//! [START storage_create_bucket_with_object_retention]
//! [create-bucket-with-object-retention]
namespace gcs = ::google::cloud::storage;
using ::google::cloud::StatusOr;
Expand All @@ -41,6 +42,7 @@ void CreateBucketWithObjectRetention(google::cloud::storage::Client client,
<< "\n";
}
//! [create-bucket-with-object-retention]
//! [END storage_create_bucket_with_object_retention]
(std::move(client), argv.at(0), argv.at(1));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ void GetObjectRetention(google::cloud::storage::Client client,

void PatchObjectRetention(google::cloud::storage::Client client,
std::vector<std::string> const& argv) {
//! [patch-object-retention]
//! [START storage_set_object_retention_policy] [patch-object-retention]
namespace gcs = ::google::cloud::storage;
using ::google::cloud::StatusOr;
[](gcs::Client client, std::string const& bucket_name,
Expand All @@ -113,7 +113,7 @@ void PatchObjectRetention(google::cloud::storage::Client client,
std::cout << "Successfully updated object retention configuration: "
<< *updated << "\n";
}
//! [patch-object-retention]
//! [END storage_set_object_retention_policy] [patch-object-retention]
(std::move(client), argv.at(0), argv.at(1));
}

Expand Down
3 changes: 1 addition & 2 deletions google/cloud/storage/object_retention.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
*
* Objects under retention cannot be deleted or overwritten until their
* retention expires. Objects with a "Locked" retention cannot have their
* retention period decreased or incce. The soft delete policy prevents
* soft-deleted objects from being permanently deleted.
* retention period decreased or increased.
*/
struct ObjectRetention {
std::string mode;
Expand Down

0 comments on commit 08c1e9a

Please sign in to comment.