Skip to content

Commit

Permalink
fix: missing dependency for WIN32
Browse files Browse the repository at this point in the history
We were missing a direct dependency on Windows. It probably went
unnoticed because in our tests we get this dependency indirectly. It is
important for Conda support.
  • Loading branch information
coryan committed Dec 9, 2021
1 parent 654a652 commit 08cc053
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions google/cloud/storage/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,11 @@ target_link_libraries(
OpenSSL::SSL
OpenSSL::Crypto
ZLIB::ZLIB)
if (WIN32)
# We use `setsockopt()` directly, which requires the ws2_32 (Winsock2 for
# Windows32?) library on Windows.
target_link_libraries(google_cloud_cpp_storage PUBLIC ws2_32)
endif ()
google_cloud_cpp_add_common_options(google_cloud_cpp_storage)
target_include_directories(
google_cloud_cpp_storage PUBLIC $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
Expand Down

0 comments on commit 08cc053

Please sign in to comment.