Manually update READMEs, quickstart, and top-level stuff

googleapis · May 23, 2024 · 5ca8cff · 5ca8cff
1 parent b366711
commit 5ca8cff
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 18 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@ breaking changes in the upcoming 3.x release. This release is scheduled for
 We are happy to announce the following GA libraries. Unless specifically noted,
 the APIs in these libraries are stable, and are ready for production use.
 
+- [Developer Connect API](/google/cloud/developerconnect/README.md)
 - [Public Certificate Authority API](/google/cloud/publicca/README.md)
 
 ## v2.24.0 - 2024-05

diff --git a/cmake/GoogleCloudCppFeatures.cmake b/cmake/GoogleCloudCppFeatures.cmake
@@ -86,6 +86,7 @@ set(GOOGLE_CLOUD_CPP_GA_LIBRARIES
     "datastore"
     "datastream"
     "deploy"
+    "developerconnect"
     "dialogflow_cx"
     "dialogflow_es"
     "discoveryengine"

diff --git a/generator/generator_config.textproto b/generator/generator_config.textproto
@@ -1903,7 +1903,7 @@ service {
 # Developer Connect
 service {
   service_proto_path: "google/cloud/developerconnect/v1/developer_connect.proto"
-  product_path: "google/cloud/developer_connect/v1"
+  product_path: "google/cloud/developerconnect/v1"
   initial_copyright_year: "2024"
   retryable_status_codes: ["kUnavailable"]
 }

diff --git a/google/cloud/developerconnect/CMakeLists.txt b/google/cloud/developerconnect/CMakeLists.txt
@@ -29,8 +29,7 @@ if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
         COMMAND
             cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
             $<TARGET_FILE:developerconnect_quickstart> GOOGLE_CLOUD_PROJECT
-            GOOGLE_CLOUD_CPP_TEST_REGION # EDIT HERE
-    )
+            GOOGLE_CLOUD_CPP_TEST_REGION)
     set_tests_properties(developerconnect_quickstart
                          PROPERTIES LABELS "integration-test;quickstart")
 endif ()
diff --git a/google/cloud/developerconnect/README.md b/google/cloud/developerconnect/README.md
@@ -18,7 +18,7 @@ this library.
 <!-- inject-quickstart-start -->
 
 ```cc
-#include "google/cloud/developerconnect/v1/ EDIT HERE _client.h"
+#include "google/cloud/developerconnect/v1/developer_connect_client.h"
 #include "google/cloud/location.h"
 #include <iostream>
 
@@ -31,12 +31,12 @@ int main(int argc, char* argv[]) try {
   auto const location = google::cloud::Location(argv[1], argv[2]);
 
   namespace developerconnect = ::google::cloud::developerconnect_v1;
-  auto client = developerconnect::ServiceClient(
-      developerconnect::MakeServiceConnection());  // EDIT HERE
+  auto client = developerconnect::DeveloperConnectClient(
+      developerconnect::MakeDeveloperConnectConnection());
 
-  for (auto r : client.List /*EDIT HERE*/ (location.FullName())) {
-    if (!r) throw std::move(r).status();
-    std::cout << r->DebugString() << "\n";
+  for (auto c : client.ListConnections(location.FullName())) {
+    if (!c) throw std::move(c).status();
+    std::cout << c->DebugString() << "\n";
   }
 
   return 0;

diff --git a/google/cloud/developerconnect/quickstart/README.md b/google/cloud/developerconnect/quickstart/README.md
@@ -73,7 +73,7 @@ https://cloud.google.com/docs/authentication/production
 1. Run the example, changing the placeholder(s) to appropriate values:
 
    ```bash
-   bazel run :quickstart -- [...]
+   bazel run :quickstart -- [PROJECT_ID] [REGION]
    ```
 
 ## Using with CMake
@@ -110,7 +110,7 @@ https://cloud.google.com/docs/authentication/production
 1. Run the example, changing the placeholder(s) to appropriate values:
 
    ```bash
-   .build/quickstart [...]
+   .build/quickstart [PROJECT_ID] [REGION]
    ```
 
 ## Platform Specific Notes
@@ -151,4 +151,4 @@ set GRPC_DEFAULT_SSL_ROOTS_FILE_PATH=%cd%\roots.pem
 [grpc-roots-pem-bug]: https://github.com/grpc/grpc/issues/16571
 [homebrew-cmake-link]: https://formulae.brew.sh/formula/cmake
 [howto-setup-dev-workstation]: /doc/contributor/howto-guide-setup-development-workstation.md
-[quickstart-link]: https://cloud.google.com/developerconnect/docs/quickstart
+[quickstart-link]: https://cloud.google.com/developer-connect/docs/connect-repo
diff --git a/google/cloud/developerconnect/quickstart/quickstart.cc b/google/cloud/developerconnect/quickstart/quickstart.cc
@@ -13,7 +13,7 @@
 // limitations under the License.
 
 //! [all]
-#include "google/cloud/developerconnect/v1/ EDIT HERE _client.h"
+#include "google/cloud/developerconnect/v1/developer_connect_client.h"
 #include "google/cloud/location.h"
 #include <iostream>
 
@@ -26,12 +26,12 @@ int main(int argc, char* argv[]) try {
   auto const location = google::cloud::Location(argv[1], argv[2]);
 
   namespace developerconnect = ::google::cloud::developerconnect_v1;
-  auto client = developerconnect::ServiceClient(
-      developerconnect::MakeServiceConnection());  // EDIT HERE
+  auto client = developerconnect::DeveloperConnectClient(
+      developerconnect::MakeDeveloperConnectConnection());
 
-  for (auto r : client.List /*EDIT HERE*/ (location.FullName())) {
-    if (!r) throw std::move(r).status();
-    std::cout << r->DebugString() << "\n";
+  for (auto c : client.ListConnections(location.FullName())) {
+    if (!c) throw std::move(c).status();
+    std::cout << c->DebugString() << "\n";
   }
 
   return 0;

diff --git a/libraries.bzl b/libraries.bzl
@@ -146,6 +146,7 @@ GOOGLE_CLOUD_CPP_GA_LIBRARIES = [
     "datastore",
     "datastream",
     "deploy",
+    "developerconnect",
     "dialogflow_cx",
     "dialogflow_es",
     "discoveryengine",