Skip to content

Commit

Permalink
use global region
Browse files Browse the repository at this point in the history
  • Loading branch information
dbolduc committed Jul 15, 2024
1 parent 41bccfb commit 8649deb
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ breaking changes in the upcoming 3.x release. This release is scheduled for
We are happy to announce the following GA libraries. Unless specifically noted,
the APIs in these libraries are stable, and are ready for production use.

- [Developer Connect API](/google/cloud/developerconnect/README.md)
- [Privileged Access Manager API](/google/cloud/privilegedaccessmanager/README.md)

The following experimental libraries are now available:
Expand Down Expand Up @@ -76,7 +77,6 @@ change instances of `EXPECT_CALL(*mock, Method)` to
We are happy to announce the following GA libraries. Unless specifically noted,
the APIs in these libraries are stable, and are ready for production use.

- [Developer Connect API](/google/cloud/developerconnect/README.md)
- [Managed Kafka API](/google/cloud/managedkafka/README.md)

### Updated Libraries
Expand Down
6 changes: 2 additions & 4 deletions google/cloud/developerconnect/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
google_cloud_cpp_add_common_options(developerconnect_quickstart)
add_test(
NAME developerconnect_quickstart
COMMAND
cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
$<TARGET_FILE:developerconnect_quickstart> GOOGLE_CLOUD_PROJECT
GOOGLE_CLOUD_CPP_TEST_REGION)
COMMAND cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
$<TARGET_FILE:developerconnect_quickstart> GOOGLE_CLOUD_PROJECT)
set_tests_properties(developerconnect_quickstart
PROPERTIES LABELS "integration-test;quickstart")
endif ()
6 changes: 3 additions & 3 deletions google/cloud/developerconnect/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ this library.
#include <iostream>

int main(int argc, char* argv[]) try {
if (argc != 3) {
std::cerr << "Usage: " << argv[0] << " project-id location-id\n";
if (argc != 2) {
std::cerr << "Usage: " << argv[0] << " project-id\n";
return 1;
}

auto const location = google::cloud::Location(argv[1], argv[2]);
auto const location = google::cloud::Location(argv[1], "global");

namespace developerconnect = ::google::cloud::developerconnect_v1;
auto client = developerconnect::DeveloperConnectClient(
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/developerconnect/quickstart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ https://cloud.google.com/docs/authentication/production
1. Run the example, changing the placeholder(s) to appropriate values:

```bash
bazel run :quickstart -- [PROJECT_ID] [REGION]
bazel run :quickstart -- [PROJECT_ID]
```

## Using with CMake
Expand Down Expand Up @@ -110,7 +110,7 @@ https://cloud.google.com/docs/authentication/production
1. Run the example, changing the placeholder(s) to appropriate values:

```bash
.build/quickstart [PROJECT_ID] [REGION]
.build/quickstart [PROJECT_ID]
```

## Platform Specific Notes
Expand Down
6 changes: 3 additions & 3 deletions google/cloud/developerconnect/quickstart/quickstart.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
#include <iostream>

int main(int argc, char* argv[]) try {
if (argc != 3) {
std::cerr << "Usage: " << argv[0] << " project-id location-id\n";
if (argc != 2) {
std::cerr << "Usage: " << argv[0] << " project-id\n";
return 1;
}

auto const location = google::cloud::Location(argv[1], argv[2]);
auto const location = google::cloud::Location(argv[1], "global");

namespace developerconnect = ::google::cloud::developerconnect_v1;
auto client = developerconnect::DeveloperConnectClient(
Expand Down

0 comments on commit 8649deb

Please sign in to comment.