Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
coryan committed Jul 3, 2024
1 parent eacd9e4 commit 9374247
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ TEST(RetryObjectReadSourceTest, BackoffPolicyResetOnSuccess) {

EXPECT_EQ(0, num_backoff_policy_called);

// We really do not care how many times the policy is closed before we make
// We really do not care how many times the policy is cloned before we make
// the first `Read()` call. We only care about how it increases.
auto const initial_clone_count = backoff_policy_mock.NumClones();
auto source = client->ReadObject(ReadObjectRangeRequest{});
Expand Down Expand Up @@ -293,7 +293,6 @@ TEST(RetryObjectReadSourceTest, ResumePolicyOrder) {
HttpResponse{100, "", {}}}));
EXPECT_CALL(*source, Read).WillOnce(Return(TransientError()));
// No backoffs to resume after a (partially) successful request:
// EXPECT_CALL(backoff, Call).Times(1);
EXPECT_CALL(factory, Call).WillOnce(make_partial);
EXPECT_CALL(backoff, Call).Times(1);
EXPECT_CALL(factory, Call).WillOnce(make_partial);
Expand Down

0 comments on commit 9374247

Please sign in to comment.