fixes

googleapis · Nov 7, 2023 · ab5a53a · ab5a53a
1 parent 0ff35af
commit ab5a53a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 14 deletions.
diff --git a/.github/workflows/update-googleapis-sha.yml b/.github/workflows/update-googleapis-sha.yml
@@ -1,17 +1,17 @@
 name: "Update the google apis"
 
-# on: push
-on:
-  # Create the PR once a week at 12:00 on Monday.
-  schedule:
-    - cron: '0 12 * * MON'
-  push:
-    branches: [ 'ci-gha-googleapis**' ]
+on: push
+# on:
+#   # Create the PR once a week at 00:00 on Sunday.
+#   schedule:
+#     - cron: '0 0 * * SUN'
+#   push:
+#     branches: [ 'ci-gha-googleapis**' ]
 
 permissions:
    contents: write
    pull-requests: write
-   id-token: 'write'
+   id-token: write
 
 env:
   REPO: googleapis/googleapis
@@ -38,7 +38,7 @@ jobs:
       - name: Get latest commit from google apis
         run: |
           echo "COMMIT=$(curl --retry 5 -fsSL -H 'Accept: application/vnd.github.VERSION.sha' 'https://api.github.com/repos/${{ env.REPO }}/commits/${{ env.BRANCH}}')" >> $GITHUB_ENV
-      - name: Get the SHA for google apis and store the archieve in our storage bucket
+      - name: Get the SHA for google apis and store the archive in our storage bucket
         run: |
           DOWNLOAD="$(mktemp)"
           curl -fsSL --retry 5 "https://github.com/${{ env.REPO }}/archive/${{ env.COMMIT }}.tar.gz" -o "${DOWNLOAD}"
@@ -96,7 +96,7 @@ jobs:
         run: |
           git config user.name 'Anonymous'
           git config user.email '<>'
-          git commit -m"chore: update googleapis SHA circa $(date +%Y-%m-%d)" \
+          git commit -m"chore: update googleapis SHA" \
           bazel/google_cloud_cpp_deps.bzl cmake/GoogleapisConfig.cmake
           if ! git diff --quiet external/googleapis/protodeps \
           external/googleapis/protolists; then
@@ -113,7 +113,6 @@ jobs:
           body: >
             This PR is auto-generated by
             [updated-googleapis-sha](https://github.com/googleapis/google-cloud-cpp/.github/workflows/update-googleapis-sha).
-            Thre new sha is ${SHA256}
+            - The new SHA256 is  ${{ env.SHA256 }}
+            - The archive can be found at https://github.com/${{ env.REPO }}/archive/${{ env.COMMIT }}.tar.gz
           labels: dependencies
-        env:
-          SHA256: ${{ env.SHA256 }}
diff --git a/doc/contributor/howto-guide-update-googleapis-sha.md b/doc/contributor/howto-guide-update-googleapis-sha.md
@@ -1,7 +1,7 @@
 # How-to Guide: Update googleapis SHA
 
 As of 11-07-2023, we are using a GHA to update the googleapis SHA. This runs
-once a week on Mondays at noon and is generated by
+once a week on Sundays and is generated by
 [updated-googleapis-sha](updated-googleapis-sha).
 
 This document remains for anyone who wishes to perform the manual steps. This