Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
coryan committed Jan 11, 2022
1 parent 53775b2 commit f0071bb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
5 changes: 2 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,8 @@ storage::internal::ResumableUploadResource{
}
```

That is, you need to re-order the fields **and** change increase the
`value` to reflect the number of committed bytes vs. the index in the
last committed byte.
That is, you need to re-order the fields **and** increase the `value` to reflect
the number of committed bytes vs. the index in the last committed byte.

Changing the order of the fields was intentional. It will create a build
failure, which is easier to detect and repair than a run-time error in
Expand Down
1 change: 0 additions & 1 deletion google/cloud/storage/internal/resumable_upload_session.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ StatusOr<std::uint64_t> ParseRangeHeader(std::string const& range) {
// We expect a `Range:` header in the format described here:
// https://cloud.google.com/storage/docs/json_api/v1/how-tos/resumable-upload
// that is the value should match `bytes=0-[0-9]+`:

char const prefix[] = "bytes=0-";
auto constexpr kPrefixLen = sizeof(prefix) - 1;
if (range.rfind(prefix, 0) != 0) {
Expand Down

0 comments on commit f0071bb

Please sign in to comment.