Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async streams are not traced across threads #14371

Closed
3 tasks done
dbolduc opened this issue Jun 25, 2024 · 3 comments
Closed
3 tasks done

Async streams are not traced across threads #14371

dbolduc opened this issue Jun 25, 2024 · 3 comments
Labels
cpp: opentelemetry type: cleanup An internal cleanup or hygiene concern.

Comments

@dbolduc
Copy link
Member

dbolduc commented Jun 25, 2024

auto start_span = internal::MakeSpan("Start");
return impl_->Start().then(

We need to mark the stored span_ as the parent of these Start and Finish operations.

Otherwise, we get broken traces that show only Start and no Finish.


Tasks

Set parent for "Start" and "Finish" spans for...

  • AsyncReadWriteRpcTracing
  • AsyncStreamingReadRpcTracing
  • AsyncStreamingWriteRpcTracing
@coryan
Copy link
Contributor

coryan commented Jul 2, 2024

Is this done then?

@dbolduc
Copy link
Member Author

dbolduc commented Jul 2, 2024

The functional stuff is done. There is a cleanup I want to do.

@dbolduc
Copy link
Member Author

dbolduc commented Jul 2, 2024

Nevermind about the cleanup. Closing.

@dbolduc dbolduc closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp: opentelemetry type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

2 participants