Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel): async read write stream tracing #14379

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 27, 2024

Part of the work for #14371


Running the streaming_pull_subscriber cpp sample:

image


This change is Reviewable

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.09%. Comparing base (d9ffe82) to head (8687c2b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14379   +/-   ##
=======================================
  Coverage   93.09%   93.09%           
=======================================
  Files        2191     2191           
  Lines      193032   193037    +5     
=======================================
+ Hits       179705   179716   +11     
+ Misses      13327    13321    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review June 27, 2024 01:07
@dbolduc dbolduc requested a review from a team as a code owner June 27, 2024 01:07
@dbolduc dbolduc merged commit d0e00f9 into googleapis:main Jun 27, 2024
66 checks passed
@dbolduc dbolduc deleted the otel-fix-async-bidi-tracing branch June 27, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants