-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider "bazel sync" instead of "bazel fetch" #6140
Comments
I think we want to keep google-cloud-cpp/ci/cloudbuild/builds/lib/bazel.sh Lines 42 to 47 in a6329c1
To simply I think the simpler invocation is supposed to download all the deps that are necessary. And in an experiment on my local machine, it appeared to do just that. I did a clean |
Fixes: googleapis#6140 We only need to `bazel fetch ...`, which should get everything we need for a `bazel build ...`. The extra packages that we previously had listed were either redundant, or unnecessary, for example, a `bazel build ...` never downloaded (or needed) `@go_sdk//...` in my local experiments.
Well, I just found #5346, which seems to suggest that I'm wrong... let me do a bit more investigation. |
I think we should be able to only specify Regardless, for the purpose of this issue, we want to keep |
We use
bazel fetch
in our (Bazel) CI builds to prevent flakes caused by failed downloads. It seems like we could simplify this by usingbazel sync
instead.fetch
requires listing the rules that will be executed, and some indirect dependencies.sync
seems to download things we do not need, e.g., the SDKs for Windows when compiling on Linux.The text was updated successfully, but these errors were encountered: