-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rest): too many debug headers #10054
Conversation
We were injecting a `:curl-peer` pseudo-header (usually used for troubleshooting) for each `Read()` call. The existing tests did not catch this because this headers were never exposed to the application layer either.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 94.22% // Head: 94.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10054 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 1527 1528 +1
Lines 141822 141886 +64
=======================================
+ Hits 133633 133696 +63
- Misses 8189 8190 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @coryan)
We were injecting a
:curl-peer
pseudo-header (usually used for troubleshooting) for eachRead()
call. The existing tests did not catch this because this headers were never exposed to the application layer either.This change is