Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(bigtable): add *Client samples #10149

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 31, 2022

Add examples showing how to override the default endpoint and default authentication.

Fixes #10143 and fixes #10144


This change is Reviewable

@product-auto-label product-auto-label bot added api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples. labels Oct 31, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 5bdc02c53c805b20a59c9a2499bde19c5c374156

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 93.98% // Head: 93.98% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (593432e) compared to base (7ddabb9).
Patch coverage: 95.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10149      +/-   ##
==========================================
- Coverage   93.98%   93.98%   -0.01%     
==========================================
  Files        1524     1525       +1     
  Lines      140472   140517      +45     
==========================================
+ Hits       132024   132061      +37     
- Misses       8448     8456       +8     
Impacted Files Coverage Δ
google/cloud/bigtable/examples/client_samples.cc 95.55% <95.55%> (ø)
google/cloud/internal/async_connection_ready.cc 89.36% <0.00%> (-4.26%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.51%) ⬇️
google/cloud/storage/parallel_upload.cc 98.28% <0.00%> (-0.35%) ⬇️
google/cloud/pubsub/samples/samples.cc 90.70% <0.00%> (-0.08%) ⬇️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️
google/cloud/internal/async_rpc_details.h 100.00% <0.00%> (+5.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

google/cloud/bigtable/examples/client_samples.cc Outdated Show resolved Hide resolved
google/cloud/bigtable/doc/bigtable-main.dox Outdated Show resolved Hide resolved
google/cloud/bigtable/doc/bigtable-main.dox Outdated Show resolved Hide resolved
google/cloud/bigtable/doc/bigtable-main.dox Outdated Show resolved Hide resolved
google/cloud/bigtable/doc/bigtable-main.dox Outdated Show resolved Hide resolved
@coryan coryan marked this pull request as ready for review October 31, 2022 20:04
@coryan coryan requested a review from a team as a code owner October 31, 2022 20:04
Add examples showing how to override the default endpoint and default
authentication.
@coryan coryan force-pushed the doc-bigtable-add-client-samples branch from 5bdc02c to 593432e Compare October 31, 2022 20:39
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 593432e1b69e9cef89df7931d15919219163daab

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the samples!

@coryan coryan merged commit 66554c8 into googleapis:main Oct 31, 2022
@coryan coryan deleted the doc-bigtable-add-client-samples branch October 31, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigtable default endpoints Bigtable default authentication credentials
3 participants