-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bidirectional streams are GA #10340
feat!: bidirectional streams are GA #10340
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.85% // Head: 93.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #10340 +/- ##
=======================================
Coverage 93.85% 93.86%
=======================================
Files 1597 1597
Lines 145394 145394
=======================================
+ Hits 136462 136467 +5
+ Misses 8932 8927 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Fixes #10307
Drop the
ExperimentalTag
from bidirectional streaming APIs, as discussed in our team meeting.I decided to just update the ABI dumps. I considered making the following change:
We make the same guarantees about experimental APIs as we do with internal APIs..... but ignoring them in
check-api
just feels incautious to me. I would be happy to update the build if others disagree, though.I did not update the CHANGELOG. We can write something for the release.
This change is