Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: declutter landing page #11439

Merged
merged 8 commits into from
May 1, 2023
Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Apr 29, 2023

Use separate files for the authentication and endpoint snippets.
Just link these files from the landing page.

Part of the work for #10157


This change is Reviewable

@coryan coryan changed the title Doc declutter landing page doc: declutter landing page Apr 29, 2023
@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (90a6882) 93.78% compared to head (aa527a6) 93.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11439   +/-   ##
=======================================
  Coverage   93.78%   93.78%           
=======================================
  Files        1805     1805           
  Lines      162337   162367   +30     
=======================================
+ Hits       152244   152275   +31     
+ Misses      10093    10092    -1     
Impacted Files Coverage Δ
generator/internal/scaffold_generator.cc 86.55% <100.00%> (+0.92%) ⬆️
generator/internal/scaffold_generator_test.cc 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review April 29, 2023 01:53
@coryan coryan requested a review from a team as a code owner April 29, 2023 01:53
@coryan coryan force-pushed the doc-declutter-landing-page branch from dfeb73f to aa527a6 Compare April 29, 2023 21:17
@coryan coryan added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels May 1, 2023
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 304 of 304 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @coryan)

@coryan coryan merged commit c7314ed into googleapis:main May 1, 2023
@coryan coryan deleted the doc-declutter-landing-page branch May 1, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants