Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): add cloud storage subscription sample #12088

Merged

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Jul 13, 2023

Part of #11720


This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner July 13, 2023 18:52
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 13, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@snippet-bot
Copy link

snippet-bot bot commented Jul 13, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Jul 13, 2023
@alevenberg alevenberg force-pushed the issue-11720-cloud-storage-sample branch from c0a4c66 to 292de72 Compare July 13, 2023 18:54
@alevenberg alevenberg added the status: blocked Resolving the issue is dependent on other work. label Jul 13, 2023
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we run this as part of the AutoRun() function?

@alevenberg
Copy link
Member Author

Added the sample to AutoRun

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 81.81% and project coverage change: -0.01 ⚠️

Comparison is base (40f58f5) 93.60% compared to head (5c8dcb1) 93.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12088      +/-   ##
==========================================
- Coverage   93.60%   93.60%   -0.01%     
==========================================
  Files        2012     2012              
  Lines      176155   176177      +22     
==========================================
+ Hits       164896   164907      +11     
- Misses      11259    11270      +11     
Impacted Files Coverage Δ
google/cloud/pubsub/samples/samples.cc 87.07% <81.81%> (-0.01%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alevenberg alevenberg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 14, 2023
google/cloud/pubsub/samples/samples.cc Outdated Show resolved Hide resolved
@alevenberg alevenberg removed status: blocked Resolving the issue is dependent on other work. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 19, 2023
@alevenberg alevenberg force-pushed the issue-11720-cloud-storage-sample branch from de3d825 to b86bf75 Compare July 19, 2023 17:11
@alevenberg alevenberg temporarily deployed to internal July 19, 2023 17:11 — with GitHub Actions Inactive
@coryan coryan temporarily deployed to internal July 20, 2023 18:49 — with GitHub Actions Inactive
@alevenberg alevenberg merged commit 5fca506 into googleapis:main Jul 20, 2023
51 checks passed
@alevenberg alevenberg deleted the issue-11720-cloud-storage-sample branch July 20, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants