Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): add unwrapped subscription sample #12090

Merged

Conversation

alevenberg
Copy link
Member

@alevenberg alevenberg commented Jul 13, 2023

Part of #11720


This change is Reviewable

@alevenberg alevenberg requested a review from a team as a code owner July 13, 2023 22:13
@snippet-bot
Copy link

snippet-bot bot commented Jul 13, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Jul 13, 2023
@alevenberg alevenberg added status: blocked Resolving the issue is dependent on other work. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 82.22% and no project coverage change.

Comparison is base (25023b8) 93.58% compared to head (4118ef3) 93.59%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12090   +/-   ##
=======================================
  Coverage   93.58%   93.59%           
=======================================
  Files        2012     2012           
  Lines      176074   176115   +41     
=======================================
+ Hits       164785   164827   +42     
+ Misses      11289    11288    -1     
Impacted Files Coverage Δ
google/cloud/pubsub/samples/samples.cc 87.08% <74.07%> (-0.01%) ⬇️
google/cloud/pubsub/subscription_builder.h 96.23% <90.90%> (-0.26%) ⬇️
google/cloud/pubsub/subscription_builder_test.cc 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alevenberg
Copy link
Member Author

Submit on 07/17/23

@alevenberg alevenberg force-pushed the pubsub-unwrapped-push-subscriptuon branch from 4937e49 to 4e7a9d9 Compare July 14, 2023 18:41
@alevenberg alevenberg removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Jul 17, 2023
@alevenberg alevenberg force-pushed the pubsub-unwrapped-push-subscriptuon branch from 4e7a9d9 to f20cc53 Compare July 18, 2023 14:38
@alevenberg alevenberg temporarily deployed to internal July 18, 2023 14:38 — with GitHub Actions Inactive
@alevenberg alevenberg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2023
@alevenberg alevenberg temporarily deployed to internal July 18, 2023 18:30 — with GitHub Actions Inactive
@alevenberg alevenberg merged commit d1d6a00 into googleapis:main Jul 18, 2023
71 checks passed
@alevenberg alevenberg deleted the pubsub-unwrapped-push-subscriptuon branch July 18, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants