Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(bigtable): log more to deflake a test #12094

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 14, 2023

This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 62.96% and project coverage change: -0.01 ⚠️

Comparison is base (0d0fa69) 93.69% compared to head (4078e40) 93.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12094      +/-   ##
==========================================
- Coverage   93.69%   93.68%   -0.01%     
==========================================
  Files        2012     2012              
  Lines      175703   175713      +10     
==========================================
- Hits       164619   164615       -4     
- Misses      11084    11098      +14     
Impacted Files Coverage Δ
...cloud/testing_util/check_predicate_becomes_false.h 69.69% <16.66%> (-30.31%) ⬇️
google/cloud/bigtable/polling_policy_test.cc 100.00% <100.00%> (ø)
google/cloud/bigtable/rpc_retry_policy_test.cc 97.97% <100.00%> (ø)
google/cloud/internal/retry_policy_impl_test.cc 100.00% <100.00%> (ø)
google/cloud/polling_policy_test.cc 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review July 14, 2023 14:13
@coryan coryan requested a review from a team as a code owner July 14, 2023 14:13
@coryan coryan enabled auto-merge (squash) July 14, 2023 14:30
@coryan coryan merged commit c8a58a0 into googleapis:main Jul 14, 2023
57 checks passed
@coryan coryan deleted the test-bigtable-improve-logging-for-flake branch July 14, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants