cleanup(otel): tests use scoped span catcher #12097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12097 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 2012 2012
Lines 175713 175720 +7
=======================================
+ Hits 164618 164626 +8
+ Misses 11095 11094 -1
☔ View full report in Codecov by Sentry. |
coryan
approved these changes
Jul 14, 2023
devbww
reviewed
Jul 14, 2023
dbolduc
force-pushed
the
otel-span-catcher-test-cleanup
branch
from
4bf483d
to
6f32cd3
Compare
devbww
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a scoped span catcher object, that restores the
NoopTracerProviderafter a test runs.If we forget to
InstallSpanCatcher()in a test that creates spans, we can see a different valid test fail, because it picks up the extra spans. I don't quite understand why that behavior happens, but I think this PR will eliminate it.Keep the interface the same so I don't have to update N tests.
This change is