cleanup(rest): only trace if enabled #12098
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were always including the REST tracing client. Now, only include it if tracing is enabled, as determined by the
Options
.Make(Default|Pooled)RestClient(...)
are one of those interfaces (likeMake*Connection()
) that are difficult to cover with unit tests. If someone asks, I can try to cover it in an integration test.NOTE: I also changed a
to a
GetDefaultCurlHandleFactory(options);
The difference is that
GetDefaultCurlHandleFactory(options)
checks ifCARootsFilePathOption
is empty, before using it andCAPathOption
:google-cloud-cpp/google/cloud/internal/curl_handle_factory.cc
Line 39 in 08e52b4
I think that is the one we want. @coryan can you speak to this?
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)