Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GCS+gRPC): URL encode routing params for streaming writes #12448

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix(GCS+gRPC): URL encode routing params for streaming writes #12448

merged 2 commits into from
Aug 23, 2023

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Aug 23, 2023 •
edited by coryan
Loading

Part of the work for #12232

This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal August 23, 2023 05:03 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 23, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (035695d) 93.60% compared to head (de84be3) 93.62%.
Report is 3 commits behind head on main.

❗ Current head de84be3 differs from pull request most recent head 96e15dc. Consider uploading reports for the commit 96e15dc to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12448      +/-   ##
==========================================
+ Coverage   93.60%   93.62%   +0.02%     
==========================================
  Files        2036     2035       -1     
  Lines      180304   180225      -79     
==========================================
- Hits       168781   168744      -37     
+ Misses      11523    11481      -42
Files Changed Coverage Δ
google/cloud/storage/internal/grpc/stub_test.cc 100.00% <ø> (ø)
.../storage/internal/grpc/configure_client_context.cc 100.00% <100.00%> (ø)
...age/internal/grpc/configure_client_context_test.cc 100.00% <100.00%> (ø)

... and 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 23, 2023 06:07
@dbolduc dbolduc requested a review from a team as a code owner August 23, 2023 06:07
coryan
coryan approved these changes Aug 23, 2023
View reviewed changes
google/cloud/storage/internal/grpc/configure_client_context.cc Outdated
context.AddMetadata(
"x-goog-request-params",
"bucket=projects%2F_%2Fbuckets%2F" +
google::cloud::internal::UrlEncode(request.bucket_name()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuck. Can we just do UrlEncode("projects/_/buckets/" + request.bucket_name()) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dbolduc dbolduc force-pushed the url-encode-storage-client-streaming-params branch from de84be3 to 96e15dc Compare August 23, 2023 17:08
@dbolduc dbolduc temporarily deployed to internal August 23, 2023 17:08 — with GitHub Actions Inactive
@dbolduc dbolduc enabled auto-merge (squash) August 23, 2023 17:18
@dbolduc dbolduc merged commit a97d711 into googleapis:main Aug 23, 2023
@dbolduc dbolduc deleted the url-encode-storage-client-streaming-params branch August 23, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbolduc @coryan