Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmake): client libraries link to shared proto deps #12514

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

@dbolduc dbolduc temporarily deployed to internal August 31, 2023 16:43 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (bcbc8d4) 93.63% compared to head (ba8b5d5) 93.62%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12514      +/-   ##
==========================================
- Coverage   93.63%   93.62%   -0.01%     
==========================================
  Files        2043     2043              
  Lines      180935   180935              
==========================================
- Hits       169413   169408       -5     
- Misses      11522    11527       +5     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review August 31, 2023 18:15
@dbolduc dbolduc requested a review from a team as a code owner August 31, 2023 18:15
@dbolduc dbolduc merged commit ad05d3f into googleapis:main Aug 31, 2023
53 checks passed
@dbolduc dbolduc deleted the fix-cmake-shared-protos branch August 31, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants