Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute): add missing bazelrc file #12856

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 10, 2023

This is necessary (but not sufficient) to get the quickstart building.

Motivated by #12854


This change is Reviewable

@coryan coryan temporarily deployed to internal October 10, 2023 12:59 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Oct 10, 2023
@coryan coryan marked this pull request as ready for review October 10, 2023 13:11
@coryan coryan requested a review from a team as a code owner October 10, 2023 13:11
@coryan coryan enabled auto-merge (squash) October 10, 2023 13:12
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1d94ab4) 93.55% compared to head (e9f1a43) 93.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12856      +/-   ##
==========================================
- Coverage   93.55%   93.55%   -0.01%     
==========================================
  Files        2075     2075              
  Lines      180653   180653              
==========================================
- Hits       169012   169009       -3     
- Misses      11641    11644       +3     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit 505ea27 into googleapis:main Oct 10, 2023
54 checks passed
@coryan coryan deleted the fix-compute-add-missing-bazelrc branch October 10, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: compute Issues related to the Compute Engine API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants