Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compute): build with Bazel and MSVC #12877

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix(compute): build with Bazel and MSVC #12877

merged 2 commits into from
Oct 11, 2023

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 11, 2023 •
edited
Loading

@coryan coryan temporarily deployed to internal October 11, 2023 21:08 — with GitHub Actions Inactive
@product-auto-label product-auto-label bot added the api: compute Issues related to the Compute Engine API. label Oct 11, 2023
@coryan coryan mentioned this pull request Oct 11, 2023
Merged
@coryan coryan marked this pull request as ready for review October 11, 2023 21:15
@coryan coryan requested a review from a team as a code owner October 11, 2023 21:15
@coryan coryan enabled auto-merge (squash) October 11, 2023 21:18
@coryan coryan temporarily deployed to internal October 11, 2023 21:38 — with GitHub Actions Inactive
@coryan coryan disabled auto-merge October 11, 2023 21:47
@coryan coryan temporarily deployed to internal October 11, 2023 21:48 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5862f09) 93.54% compared to head (0ef5794) 93.54%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12877      +/-   ##
==========================================
- Coverage   93.54%   93.54%   -0.01%     
==========================================
  Files        2075     2075              
  Lines      180754   180754              
==========================================
- Hits       169095   169094       -1     
- Misses      11659    11660       +1

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit ff11eda into googleapis:main Oct 11, 2023
54 checks passed
@coryan coryan deleted the fix-compute-build-with-bazel-and-msvc branch October 11, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devbww devbww devbww approved these changes

Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coryan @devbww