New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): get future value before returning #13241

Merged

alevenberg merged 12 commits into googleapis:main from alevenberg:fix-3

Dec 8, 2023

+114 −3

google/cloud/pubsub/internal/tracing_batch_sink.cc

-Original file line number
+Diff line change
@@ Expand Up / @@ -178,7 +178,7 @@ class TracingBatchSink : public BatchSink { @@
                 internal::EndSpan(*span);
               }
               internal::DetachOTelContext(oc);
-              return f;
+              return f.get();
             });
       }
@@ Expand Down @@