impl(GCS+gRPC): histogram buckets for gRPC metrics #14135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryan
force-pushed
the
impl-GCS+gRPC-histograms
branch
from
21b2145
to
b2babdb
Compare
coryan
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14135 +/- ##
==========================================
+ Coverage 93.23% 93.79% +0.55%
==========================================
Files 2206 2295 +89
Lines 192051 202878 +10827
==========================================
+ Hits 179065 190293 +11228
+ Misses 12986 12585 -401 ☔ View full report in Codecov by Sentry. |
The gRPC metrics include histograms, but the default buckets are not very useful.
coryan
force-pushed
the
impl-GCS+gRPC-histograms
branch
from
b2babdb
to
02c20be
Compare
|
@frankyn can you take a look? You probably have the most context here. |
frankyn
approved these changes
May 10, 2024
| std::vector<double> MakeSizeHistogramBoundaries() { | ||
| auto constexpr kKiB = std::int64_t{1024}; | ||
| auto constexpr kMiB = 1024 * kKiB; | ||
| auto constexpr kGiB = 1024 * kMiB; |
There was a problem hiding this comment.
k represents constant if iiuc https://stackoverflow.com/questions/5016622/where-does-the-k-prefix-for-constants-come-from; doesn't matter just got confused.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC metrics include histograms, but the default buckets are not
very useful.
Part of the work for #13998
This change is