impl(GCS+gRPC): full configuration for metrics #14247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14247 +/- ##
=======================================
Coverage 93.26% 93.26%
=======================================
Files 2211 2213 +2
Lines 193188 193275 +87
=======================================
+ Hits 180173 180257 +84
- Misses 13015 13018 +3 ☔ View full report in Codecov by Sentry. |
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr3
branch
from
ce6e5a0
to
3a13879
Compare
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr3
branch
from
3a13879
to
5a4e3e3
Compare
This computes all the configuration parameter for the gRPC metric exporter.
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr3
branch
from
5a4e3e3
to
a327b3e
Compare
dbolduc
approved these changes
May 17, 2024
google/cloud/storage/internal/grpc/metrics_exporter_impl_test.cc
Outdated
Show resolved
Hide resolved
dbolduc
reviewed
May 17, 2024
google/cloud/storage/internal/grpc/metrics_exporter_impl_test.cc
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This computes all the configuration parameter for the gRPC metric
exporter.
Part of the work for #13998
This change is