impl(GCS+gRPC): export metrics with desired monitored resource #14270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14270 +/- ##
=======================================
Coverage 93.58% 93.59%
=======================================
Files 2318 2318
Lines 207177 207163 -14
=======================================
+ Hits 193886 193893 +7
+ Misses 13291 13270 -21 ☔ View full report in Codecov by Sentry. |
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr7
branch
from
c16d4d8
to
a55d4d0
Compare
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr7
branch
from
a55d4d0
to
64a1d1b
Compare
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr7
branch
from
64a1d1b
to
464cc76
Compare
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr7
branch
from
464cc76
to
ca3e8ef
Compare
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr7
branch
from
ca3e8ef
to
7e4224d
Compare
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr7
branch
from
7e4224d
to
a1e9b19
Compare
coryan
force-pushed
the
impl-GCS+gRPC-always-enable-gRPC-metrics-pr7
branch
from
a1e9b19
to
d5d80b5
Compare
scotthart
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @coryan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13998
This change is