Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: clang-tidy for oauth2, storagecontrol #14338

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 14, 2024

My opinion on: #14332 (comment)

Also, I notice that oauth2 previously escaped clang-tidy. Throwing it in the storage shard makes some sense.


This change is Reviewable

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (b010c3d) to head (fa6b91a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14338      +/-   ##
==========================================
- Coverage   93.78%   93.23%   -0.56%     
==========================================
  Files        2268     2181      -87     
  Lines      202242   191469   -10773     
==========================================
- Hits       189682   178514   -11168     
- Misses      12560    12955     +395     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement, even if the samples for google/cloud/batch are not covered.

@dbolduc dbolduc marked this pull request as ready for review June 14, 2024 18:33
@dbolduc dbolduc requested review from a team as code owners June 14, 2024 18:33
@dbolduc
Copy link
Member Author

dbolduc commented Jun 14, 2024

the samples for google/cloud/batch are not covered.

True. I missed this. I checked locally and the batch samples are compliant.

I am tempted to throw it in the bigquery shard... But I think I will merge this first.

@dbolduc dbolduc merged commit 29b8a83 into googleapis:main Jun 14, 2024
64 checks passed
@dbolduc dbolduc deleted the clang-tidy-shards branch June 14, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants