Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): buckets with object retention #14350

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 18, 2024

Buckets can be created with object retention enabled. If objects in
these buckets also have retention enabled, then the objects may not be
deleted before the retention timestamp. A future PR will introduce the
changes to support object metadata changes w.r.t. object retention.

Part of the fixes for #12994


This change is Reviewable

Buckets can be created with object retention enabled. If objects in
these buckets also have retention enabled, then the objects may not be
deleted before the retention timestamp. A future PR will introduce the
changes to support object metadata changes w.r.t. object retention.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.18%. Comparing base (e7ac801) to head (96b15e7).

Files Patch % Lines
google/cloud/storage/enable_object_retention.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14350   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files        2183     2187    +4     
  Lines      192192   192250   +58     
=======================================
+ Hits       179100   179155   +55     
- Misses      13092    13095    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review June 18, 2024 18:52
@coryan coryan requested review from a team as code owners June 18, 2024 18:52
@coryan coryan merged commit 99acf8f into googleapis:main Jun 18, 2024
66 checks passed
@coryan coryan deleted the feat-storage-object-retention-pr1 branch June 18, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants