Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): only backoff before resume attempts #14427

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix(storage): only backoff before resume attempts #14427

merged 2 commits into from
Jul 3, 2024

Commits on Jul 3, 2024

  1. fix(storage): only backoff before resume attempts 

    `storage::Client::ReadObject()` resumes a download that gets
interrupted (controlled by policy). On the first resume attempt, the
library does not back off (sleep), becuase there is no reason to believe
the problem is load related. If the first resume fails, the library
backsoff before each attempt, as the problem might be load related after
this point.

The library was *also* backing off before issuing the first `Read()` on
the newly created source of data. That effectively doubles the backoff
time, and leaves the resumed connection idle for (potentially) a long
time when there are multiple resume attempts needed.
    @coryan
    coryan committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    eacd9e4 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @coryan
    coryan committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9374247 View commit details
    Browse the repository at this point in the history