ci: use bzlmod module for curl #14467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14467 +/- ##
==========================================
- Coverage 93.59% 93.58% -0.01%
==========================================
Files 2315 2316 +1
Lines 207140 207146 +6
==========================================
- Hits 193871 193864 -7
- Misses 13269 13282 +13 ☔ View full report in Codecov by Sentry. |
coryan
force-pushed
the
chore-use-bzlmod-module-for-curl
branch
from
0dc9cdd
to
3db9092
Compare
dbolduc
reviewed
Jul 15, 2024
| @@ -41,18 +41,26 @@ extern "C" size_t CurlOnWriteData(char* ptr, size_t size, size_t nmemb, | |||
| return size * nmemb; | |||
| } | |||
|
|
|||
| struct CurlPtrCleanup { | |||
There was a problem hiding this comment.
#include "google/cloud/internal/curl_wrappers.h"
instead of redefining. Same goes for CurlSListFreeAll.
There was a problem hiding this comment.
I did not want to use google::cloud::internal in an example.
There was a problem hiding this comment.
My mistake. I didn't notice the file.
| @@ -60,13 +60,20 @@ nlohmann::json MakeChatPayload(BuildStatus const& bs) { | |||
| return nlohmann::json{{"text", std::move(text)}}; | |||
| } | |||
|
|
|||
| struct CurlPtrCleanup { | |||
There was a problem hiding this comment.
These do not link google::cloud::*
Comment on lines
+73
to
+76
| using Headers = std::unique_ptr<curl_slist, CurlSListFreeAll>; | ||
| auto const headers = Headers{curl_slist_append(nullptr, kContentType)}; | ||
| using CurlHandle = std::unique_ptr<CURL, CurlPtrCleanup>; | ||
| auto curl = CurlHandle(curl_easy_init()); |
There was a problem hiding this comment.
auto const headers = CurlHeaders{curl_slist_append(nullptr, kContentType)};
auto curl = CurlPtr(curl_easy_init());
Comment on lines
+59
to
+63
| using Headers = std::unique_ptr<curl_slist, CurlSListFreeAll>; | ||
| auto const headers = | ||
| Headers{curl_slist_append(nullptr, authorization.c_str())}; | ||
| using CurlHandle = std::unique_ptr<CURL, CurlPtrCleanup>; | ||
| auto curl = CurlHandle(curl_easy_init()); |
There was a problem hiding this comment.
Same. I do not think we should use internal types in an example.
dbolduc
approved these changes
Jul 15, 2024
cuiy0006
pushed a commit
to cuiy0006/google-cloud-cpp
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #11485
This change is