Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reduce spanner CreateInstance rpcs in daily build #14468

Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 12, 2024

We have been seeing flakes in our integration-daily build.

e.g. https://console.cloud.google.com/cloud-build/builds;region=us-east1/2f83568c-9612-44d5-aafe-5c03e9f7a319?project=936212892354

google/cloud/spanner/admin/integration_tests/instance_admin_integration_test.cc:187: Failure
Value of: instance
Expected: code is equal to OK and message is anything
  Actual: 176-byte object <00-46 02-C8 BC-7F 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 ... 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00>, whose status is RESOURCE_EXHAUSTED: Error in non-idempotent operation: Quota exceeded for quota metric 'Instance create requests' and limit 'Instance create requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:936212892354'. error_info={reason=RATE_LIMIT_EXCEEDED, domain=googleapis.com, metadata={gcloud-cpp.retry.reason=non-idempotent, gcloud-cpp.retry.original-message=Quota exceeded for quota metric 'Instance create requests' and limit 'Instance create requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:936212892354'., quota_location=global, gcloud-cpp.retry.function=CreateInstance, service=spanner.googleapis.com, quota_limit=AdminInstanceCreateMethodQuotaPerMinutePerProject, quota_metric=spanner.googleapis.com/admin_instance_create_method_quota, quota_limit_value=5, consumer=projects/936212892354}}, with a code that isn't equal to OK, but a message that is anything

So reduce the CreateInstance calls that run against prod. In testing GAPIC LRO's we will prefer to use CreateDatabase instead of CreateInstance.

The gRPC transcoding tests are left as is to keep their coverage the same.


This change is Reviewable

@dbolduc dbolduc marked this pull request as ready for review July 12, 2024 14:48
@dbolduc dbolduc requested a review from a team as a code owner July 12, 2024 14:48
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (e353a33) to head (f9e25e4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14468   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files        2315     2315           
  Lines      207140   207140           
=======================================
  Hits       193869   193869           
  Misses      13271    13271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

coryan
coryan previously approved these changes Jul 12, 2024
@dbolduc dbolduc dismissed coryan’s stale review July 12, 2024 16:20

I changed the code too much since this review.

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dbolduc)

@dbolduc dbolduc merged commit 8c9b852 into googleapis:main Jul 12, 2024
64 checks passed
@dbolduc dbolduc deleted the ci-avoid-spanner-createinstance-quota branch July 12, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants