Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change docker root password to a non-empty string #14470

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

cuiy0006
Copy link
Collaborator

@cuiy0006 cuiy0006 commented Jul 12, 2024

Set the docker root password to cloudcxx, because empty password doesn't work for su - in docker container.


This change is Reviewable

@cuiy0006 cuiy0006 requested a review from a team as a code owner July 12, 2024 15:22
@cuiy0006 cuiy0006 enabled auto-merge (squash) July 12, 2024 15:23
@dbolduc
Copy link
Member

dbolduc commented Jul 12, 2024

Thanks!

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (e353a33) to head (efd2ba2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14470      +/-   ##
==========================================
- Coverage   93.59%   93.58%   -0.01%     
==========================================
  Files        2315     2315              
  Lines      207140   207140              
==========================================
- Hits       193869   193858      -11     
- Misses      13271    13282      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuiy0006 cuiy0006 merged commit e7e9f7c into googleapis:main Jul 12, 2024
63 checks passed
@cuiy0006 cuiy0006 deleted the update-docker-build-chpasswd branch July 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants