Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update googleapis SHA circa 2024-07-15 #14475

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 15, 2024

PiperOrigin-RevId: 652501410


This change is Reviewable

@coryan coryan force-pushed the chore-update-googleapis-sha-circa-2024-07-15 branch from 811adfa to 4192e24 Compare July 15, 2024 18:48
@coryan coryan changed the title chore: update googleapis SHA circa 2024-07-15 chore: update googleapis SHA circa 2024-07-15 Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (841635e) to head (0e3edcd).
Report is 1 commits behind head on main.

Files Patch % Lines
...loud/bigtable/internal/bigtable_channel_refresh.cc 0.00% 2 Missing ⚠️
google/cloud/bigtable/testing/mock_bigtable_stub.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14475      +/-   ##
==========================================
- Coverage   93.59%   93.59%   -0.01%     
==========================================
  Files        2316     2316              
  Lines      207219   207222       +3     
==========================================
- Hits       193955   193951       -4     
- Misses      13264    13271       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review July 15, 2024 22:57
@coryan coryan requested a review from a team as a code owner July 15, 2024 22:57
@@ -156,6 +162,12 @@ class DefaultBigtableStub : public BigtableStub {
grpc::ClientContext& context, Options const& options,
google::bigtable::v2::ReadModifyWriteRowRequest const& request) override;

std::unique_ptr<google::cloud::internal::StreamingReadRpc<
google::bigtable::v2::ExecuteQueryResponse>>
ExecuteQuery(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@coryan coryan merged commit c0cb4d1 into googleapis:main Jul 15, 2024
63 checks passed
@coryan coryan deleted the chore-update-googleapis-sha-circa-2024-07-15 branch July 15, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants