fix(otel): avoid crashes in tracing wrappers for streams #14477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuiy0006
changed the title
cuiy0006
changed the title
dbolduc
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14477 +/- ##
========================================
Coverage 93.59% 93.59%
========================================
Files 2316 2316
Lines 207222 207354 +132
========================================
+ Hits 193953 194083 +130
- Misses 13269 13271 +2 ☔ View full report in Codecov by Sentry. |
dbolduc
reviewed
Jul 16, 2024
There was a problem hiding this comment.
Looks good. I think we need to check the early exit condition in the End() helpers, though. Other than that, I just have nits.
Aside: I would have split this up into 3 separate PRs, even though the changes are all related / basically the same. I only looked closely at the AsyncStreamingReadWriteRpcTracing changes. The comments probably apply to the other two wrappers.
dbolduc
approved these changes
Jul 17, 2024
generator/integration_tests/tests/golden_kitchen_sink_tracing_stub_test.cc
Outdated
Show resolved
Hide resolved
generator/integration_tests/tests/golden_kitchen_sink_tracing_stub_test.cc
Outdated
Show resolved
Hide resolved
generator/integration_tests/tests/golden_kitchen_sink_tracing_stub_test.cc
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the crash issue in
AsyncStreamingReadRpcTracingAsyncStreamingWriteRpcTracingAsyncStreamingReadWriteRpcTracingThe issue is caused by accessing metadata in
EndSpan()before the underlying streamStart().Closes #14458
This change is