Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(bigtable): fix some IWYU problems #14479

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 15, 2024

In this case, missing #include <iomanip> which was implicitly included
via googletest.


This change is Reviewable

In this case, missing `#include <iomanip>` which was implicitly included
via googletest.
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 15, 2024
@coryan coryan marked this pull request as ready for review July 15, 2024 23:30
@coryan coryan requested a review from a team as a code owner July 15, 2024 23:30
@coryan coryan enabled auto-merge (squash) July 15, 2024 23:30
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (cba2ca2) to head (4054d12).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14479      +/-   ##
==========================================
- Coverage   93.59%   93.59%   -0.01%     
==========================================
  Files        2316     2316              
  Lines      207219   207219              
==========================================
- Hits       193952   193950       -2     
- Misses      13267    13269       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit da41820 into googleapis:main Jul 15, 2024
63 checks passed
@coryan coryan deleted the cleanup-bigtable-fix-some-iwyu-problems branch July 16, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants