Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ApiKeyOption without UserProjectOption over REST #14748

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Oct 1, 2024

Thank you @devbww for noticing.

I added a unit test out of shame.


This change is Reviewable

@dbolduc dbolduc marked this pull request as ready for review October 1, 2024 15:18
@dbolduc dbolduc requested a review from a team as a code owner October 1, 2024 15:18
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.42%. Comparing base (bc28dc9) to head (0eea269).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14748   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files        2314     2314           
  Lines      207602   207608    +6     
=======================================
+ Hits       193952   193962   +10     
+ Misses      13650    13646    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc merged commit b0bac64 into googleapis:main Oct 1, 2024
71 checks passed
@dbolduc dbolduc deleted the fix-14745 branch October 1, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants