fix(builds): require grpc >= 1.65.4 for async_throughput_benchmark.cc

[ddelgrosso1]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (1360b76) to head (fdc9ae6).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14751      +/-   ##
==========================================
- Coverage   93.40%   93.39%   -0.01%     
==========================================
  Files        2316     2316              
  Lines      207863   207863              
==========================================
- Hits       194147   194132      -15     
- Misses      13716    13731      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[scotthart]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ddelgrosso1)

---

google/cloud/storage/benchmarks/async_throughput_benchmark.cc line 17 at r1 (raw file):

#include "google/cloud/internal/port_platform.h"
// TODO(#14750): Remove this guard once vcpkg has a newer version of grpc
#if GRPC_CPP_VERSION_MAJOR >= 1 && GRPC_CPP_VERSION_MINOR >= 65 &&       \

I would keep the old and new if statements separate.

---

google/cloud/storage/benchmarks/async_throughput_benchmark.cc line 18 at r1 (raw file):

// TODO(#14750): Remove this guard once vcpkg has a newer version of grpc
#if GRPC_CPP_VERSION_MAJOR >= 1 && GRPC_CPP_VERSION_MINOR >= 65 &&       \
    GRPC_CPP_VERSION_PATCH >= 4 && GOOGLE_CLOUD_CPP_STORAGE_HAVE_GRPC && \

The version check is going to have to be more complicated to account for something like version 1.66.1. Something like:

#if GRPC_CPP_VERSION_MAJOR > 1 || \
    GRPC_CPP_VERSION_MAJOR == 1 && GRPC_CPP_VERSION_MINOR > 65 || \
    GRPC_CPP_VERSION_MAJOR == 1 && GRPC_CPP_VERSION_MINOR == 65 && GRPC_CPP_VERSION_PATCH >= 4

[ddelgrosso1]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @scotthart)

---

google/cloud/storage/benchmarks/async_throughput_benchmark.cc line 17 at r1 (raw file):

Previously, scotthart (Scott Hart) wrote…

I would keep the old and new if statements separate.

Done.

---

google/cloud/storage/benchmarks/async_throughput_benchmark.cc line 18 at r1 (raw file):

Previously, scotthart (Scott Hart) wrote…

The version check is going to have to be more complicated to account for something like version 1.66.1. Something like:

#if GRPC_CPP_VERSION_MAJOR > 1 || \
    GRPC_CPP_VERSION_MAJOR == 1 && GRPC_CPP_VERSION_MINOR > 65 || \
    GRPC_CPP_VERSION_MAJOR == 1 && GRPC_CPP_VERSION_MINOR == 65 && GRPC_CPP_VERSION_PATCH >= 4

Done.

[scotthart]

Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ddelgrosso1)