Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates bazel used in CI #2360

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Updates bazel used in CI #2360

merged 1 commit into from
Mar 28, 2019

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented Mar 28, 2019

Updating our CI to test with 0.24.0 (the latest) version of Bazel will allow us to migrate our genrules per bazelbuild/bazel#6867


This change is Reviewable

@devjgm devjgm requested a review from coryan March 28, 2019 15:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 28, 2019
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #2360 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2360      +/-   ##
==========================================
- Coverage   92.57%   92.57%   -0.01%     
==========================================
  Files         307      307              
  Lines       19240    19252      +12     
==========================================
+ Hits        17811    17822      +11     
- Misses       1429     1430       +1
Impacted Files Coverage Δ
google/cloud/bigtable/examples/data_snippets.cc 87.19% <0%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88fefae...99d92dd. Read the comment docs.

@devjgm devjgm merged commit 8a7827e into googleapis:master Mar 28, 2019
@devjgm devjgm deleted the bazel-upgrade branch March 28, 2019 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants