Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(docs): fix doxygen warnings from clang #6560

Merged
merged 1 commit into from
May 13, 2021
Merged

Conversation

devjgm
Copy link
Contributor

@devjgm devjgm commented May 13, 2021

Related to: #6543

This fixes doxygen + clang being unable find certain resources like
stddef.h by telling clang where its -resource-dir is. After fixing
that error, there were a bunch of missing includes of proto/grpc
headers. Those were fixed by making the doxygen-docs CMake target
depend on google-cloud-cpp-protos so that those would be generated
before trying to generate the docs. Then some include path tweaks to
make things work.

I also enabled HTML timestamping so that we can see when new docs get
published.

This change supersedes
#6552, which I'm
going to close.


This change is Reviewable

@devjgm devjgm requested a review from a team as a code owner May 13, 2021 14:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3d78388851a5c4db4a14cda055ab2fda51fd8c24

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #6560 (8642474) into main (d4ab07b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6560   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files        1203     1203           
  Lines      106384   106384           
=======================================
  Hits       101932   101932           
  Misses       4452     4452           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4ab07b...8642474. Read the comment docs.

@devjgm
Copy link
Contributor Author

devjgm commented May 13, 2021

Related to: googleapis#6543

This fixes doxygen + clang being unable find certain resources like
`stddef.h` by telling clang where its `-resource-dir` is. After fixing
that error, there were a bunch of missing includes of proto/grpc
headers. Those were fixed by making the `doxygen-docs` CMake target
depend on `google-cloud-cpp-protos` so that those would be generated
before trying to generate the docs. Then some include path tweaks to
make things work.

I also enabled HTML timestamping so that we can see when new docs get
published.

This change supersedes
googleapis#6552, which I'm
goign to close.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 86424747975b9e0139559ed8581ef0dfed5969f5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@devjgm devjgm merged commit 765e427 into googleapis:main May 13, 2021
@devjgm devjgm deleted the fix-doxygen branch May 13, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants