-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(docs): fix doxygen warnings from clang #6560
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6560 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 1203 1203
Lines 106384 106384
=======================================
Hits 101932 101932
Misses 4452 4452 Continue to review full report at Codecov.
|
Step #3: GCB: https://console.cloud.google.com/cloud-build/builds;region=global/49c54674-4cbb-4696-a04d-1d086968c844;tab=detail?project=cloud-cpp-testing-resources There are still some includes that aren't found, but much fewer. I don't really understand why these aren't found, but this is probably no big deal or an issue for a future PR. |
Related to: googleapis#6543 This fixes doxygen + clang being unable find certain resources like `stddef.h` by telling clang where its `-resource-dir` is. After fixing that error, there were a bunch of missing includes of proto/grpc headers. Those were fixed by making the `doxygen-docs` CMake target depend on `google-cloud-cpp-protos` so that those would be generated before trying to generate the docs. Then some include path tweaks to make things work. I also enabled HTML timestamping so that we can see when new docs get published. This change supersedes googleapis#6552, which I'm goign to close.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Related to: #6543
This fixes doxygen + clang being unable find certain resources like
stddef.h
by telling clang where its-resource-dir
is. After fixingthat error, there were a bunch of missing includes of proto/grpc
headers. Those were fixed by making the
doxygen-docs
CMake targetdepend on
google-cloud-cpp-protos
so that those would be generatedbefore trying to generate the docs. Then some include path tweaks to
make things work.
I also enabled HTML timestamping so that we can see when new docs get
published.
This change supersedes
#6552, which I'm
going to close.
This change is