ci: avoid fedora's pkgconf which is slow
#7061
Conversation
Fixes: googleapis#7052 This avoids Fedora's `pkgconf` (a drop-in replacement for `pkg-config`) because it's too slow when dealing with `.pc` files with lots of `Requires:` deps, which we have with Abseil. Instead, we use the normal `pkg-config` binary, which seems to work better. After this PR, we should be able to upgrade to gRPC 1.39.0 (`git revert ba41d5a`)
google-cla
bot
added
the
cla: yes
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
| @@ -149,6 +149,7 @@ done < <(find "${INSTALL_PREFIX}" -type f -print0) | |||
|
|
|||
| for repo_root in "ci/verify_current_targets" "ci/verify_deprecated_targets"; do | |||
| out_dir="cmake-out/$(basename "${repo_root}")-out" | |||
| rm -f "${out_dir}/CMakeCache.txt" | |||
There was a problem hiding this comment.
This is so that we can run the cmake-install build multiple times on a machine where this file is persistent (e.g., our --docker builds). The problem is that this file caches the temporary install location from the previous invocation.
There was a problem hiding this comment.
For a separate PR: maybe the install location should not be temporary? /h/test-install or cmake-out/test-install?
There was a problem hiding this comment.
I think we want a fully clean install each time. Otherwise, if we removed an artifact in one build, the artifact may still exist on disk and we may not notice that we're still depending on the removed artifact.... well, our CI builds in GCB would notice, but we wouldn't notice on our local machines until we blew away the install directory and rebuilt. Anyway, that's why I originally installed in a new dir every time.
Codecov Report
@@ Coverage Diff @@
## main #7061 +/- ##
==========================================
- Coverage 94.49% 94.48% -0.01%
==========================================
Files 1304 1304
Lines 112327 112327
==========================================
- Hits 106140 106134 -6
- Misses 6187 6193 +6
Continue to review full report at Codecov.
|
| @@ -149,6 +149,7 @@ done < <(find "${INSTALL_PREFIX}" -type f -print0) | |||
|
|
|||
| for repo_root in "ci/verify_current_targets" "ci/verify_deprecated_targets"; do | |||
| out_dir="cmake-out/$(basename "${repo_root}")-out" | |||
| rm -f "${out_dir}/CMakeCache.txt" | |||
There was a problem hiding this comment.
For a separate PR: maybe the install location should not be temporary? /h/test-install or cmake-out/test-install?
Fixes: #7052
This avoids Fedora's
pkgconf(a drop-in replacement forpkg-config)because it's too slow when dealing with
.pcfiles with lots ofRequires:deps, which we have with Abseil. Instead, we use the normalpkg-configbinary, which seems to work better.After this PR, we should be able to upgrade to gRPC 1.39.0 (
git revert ba41d5a99818922b09eee5da148786c1d68c17f5)This change is