-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(bigtable): replace CreateDefault*Client with Make*Client #7234
cleanup(bigtable): replace CreateDefault*Client with Make*Client #7234
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7234 +/- ##
==========================================
- Coverage 93.79% 93.79% -0.01%
==========================================
Files 1338 1338
Lines 115148 115112 -36
==========================================
- Hits 108006 107968 -38
- Misses 7142 7144 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a bunch of "signed integer overflow" errors from ConnectionRefresh.Frequent
.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
@devbww I can:
At the moment, I think doing 2 makes the most sense. But it will not be done in this PR. |
FWIW, there was something similar in Spanner where we needed to enforce some constraints on google-cloud-cpp/google/cloud/spanner/internal/defaults.cc Lines 95 to 106 in c155c02
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. The "after" code is shorter and reads better. Nice!
auto credentials = | ||
grpc::CompositeChannelCredentials(channel_credentials, call_credentials); | ||
auto instance_admin_client(cbt::MakeInstanceAdminClient( | ||
project_id, gc::Options{}.set<gc::GrpcCredentialOption>(credentials))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the concrete types behind these autos, but consider whether std::move(credentials)
would be good advice in this documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I debated not even touching this. I think I should implement GUAC then see how it changes this code/documentation.
Fixes #6307
(the only remaining tasks are now captured in #7230, #7231)
This change is