Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(iam): use SetIamPolicy() read-modify-write loop in sample #7288

Merged
merged 1 commit into from
Sep 8, 2021
Merged

doc(iam): use SetIamPolicy() read-modify-write loop in sample #7288

merged 1 commit into from
Sep 8, 2021

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Sep 8, 2021 •
edited by coryan
Loading

Update the iam_set_policy sample to use the SetIamPolicy() call that
will rerun the operation after a read-modify-write race is detected.

Fixes #6919.

This change is Reviewable

@devbww
doc(iam): use SetIamPolicy() read-modify-write loop in sample
f3ada46 
Update the `iam_set_policy` sample to use the SetIamPolicy() call that
will rerun the operation after a read-modify-write race is detected.

Fixes googleapis#6919.
@product-auto-label product-auto-label bot added api: iam Issues related to the Identity and Access Management API. samples Issues that are directly related to samples. labels Sep 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f3ada4604a71bccb6c2f7850ab6d2d6a9a6bf687

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 8, 2021 •
edited
Loading

Codecov Report

Merging #7288 (f3ada46) into main (c9e2d24) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7288      +/-   ##
==========================================
- Coverage   93.78%   93.77%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      115479   115480       +1     
==========================================
- Hits       108299   108296       -3     
- Misses       7180     7184       +4
Impacted Files Coverage Δ
google/cloud/iam/samples/iam_samples.cc 54.38% <0.00%> (-0.14%) ⬇️
...torage/examples/storage_service_account_samples.cc 96.47% <0.00%> (-1.18%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
google/cloud/completion_queue_test.cc 96.95% <0.00%> (-0.20%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.02% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9e2d24...f3ada46. Read the comment docs.

@devbww devbww marked this pull request as ready for review September 8, 2021 05:39
@devbww devbww requested a review from a team as a code owner September 8, 2021 05:39
@devbww devbww merged commit 570ed91 into googleapis:main Sep 8, 2021
@devbww devbww deleted the set-iam-policy-sample branch September 8, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coryan coryan coryan approved these changes

Assignees
No one assigned
Labels
api: iam Issues related to the Identity and Access Management API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve IAM::SetIamPolicy sample code
3 participants
@devbww @google-cloud-cpp-bot @coryan